Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLL loops to address(0) #141

Merged
merged 23 commits into from
Dec 6, 2024
Merged

DLL loops to address(0) #141

merged 23 commits into from
Dec 6, 2024

Conversation

QGarchery
Copy link
Collaborator

@QGarchery QGarchery commented Jul 10, 2024 •
edited
Loading

This PR:

@QGarchery QGarchery self-assigned this Jul 10, 2024
@QGarchery QGarchery changed the title Loop DLL DLL loops to address(0) Jul 11, 2024
@QGarchery QGarchery linked an issue Jul 11, 2024 that may be closed by this pull request
DLL: use address(0) instead of head and tail #85
Closed
@QGarchery QGarchery marked this pull request as ready for review July 11, 2024 11:51
Rubilmax
Rubilmax previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much simpler

src/DoubleLinkedList.sol Outdated Show resolved Hide resolved
src/DoubleLinkedList.sol Outdated Show resolved Hide resolved
src/DoubleLinkedList.sol Outdated Show resolved Hide resolved
@QGarchery QGarchery requested a review from Rubilmax August 14, 2024 08:29
Rubilmax
Rubilmax previously approved these changes Aug 19, 2024
View reviewed changes
MathisGD
MathisGD reviewed Dec 5, 2024
View reviewed changes
src/DoubleLinkedList.sol Show resolved Hide resolved
certora/applyHarnessFifo.patch Outdated Show resolved Hide resolved
certora/helpers/MockDllFifo.sol Outdated Show resolved Hide resolved
colin-morpho
colin-morpho previously approved these changes Dec 5, 2024
View reviewed changes
colin-morpho
colin-morpho reviewed Dec 5, 2024
View reviewed changes
certora/makefile Outdated Show resolved Hide resolved
@QGarchery QGarchery merged commit 7334fb5 into main Dec 6, 2024
4 checks passed
@QGarchery QGarchery deleted the refactor/loop-dll branch December 6, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-morpho colin-morpho colin-morpho approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Rubilmax Rubilmax Rubilmax left review comments

@adhusson adhusson Awaiting requested review from adhusson

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DLL: use address(0) instead of head and tail
4 participants
@QGarchery @Rubilmax @MathisGD @colin-morpho