Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade tests #1669

Merged
merged 18 commits into from
Jan 30, 2024
Merged

Fix upgrade tests #1669

merged 18 commits into from
Jan 30, 2024

Conversation

QGarchery
Copy link
Collaborator

@QGarchery QGarchery commented Jan 4, 2024 •
edited
Loading

This PR make upgrade tests pass again by:

  • generally increasing bounds to the tests (deltas)
  • fixing the AAVE token not being handled by foundry deal cheatcode anymore, because of the packing of the balance struct (see this code)
  • fix USDC causing an issue when dealt the max amount. This is due to the blacklist bit being packed in the balance slot, which would blacklist the address being dealt the max amount
  • fix Compound tests allowing to choose a borrow amount that would use the reserves

It also displays the block number in production tests so that results are reproducible

@QGarchery QGarchery self-assigned this Jan 4, 2024
@QGarchery QGarchery marked this pull request as ready for review January 5, 2024 14:26
@QGarchery QGarchery requested review from a team, Rubilmax, MerlinEgalite and Jean-Grimal and removed request for a team January 5, 2024 14:30
Rubilmax
Rubilmax reviewed Jan 8, 2024
View reviewed changes
test/prod/ProdTest.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax previously approved these changes Jan 8, 2024
View reviewed changes
@Rubilmax
Copy link
Collaborator

Rubilmax commented Jan 8, 2024

Upgrade test fails on aave v2

Rubilmax
Rubilmax previously approved these changes Jan 8, 2024
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Jan 9, 2024
View reviewed changes
@MerlinEgalite
Copy link
Contributor

Tests are still failing cc @QGarchery

@QGarchery
Copy link
Collaborator Author

Tests are still failing cc @QGarchery

Yes, I need to investigate because bounds are getting unreasonably large at this point (1e16)

Rubilmax
Rubilmax previously approved these changes Jan 19, 2024
View reviewed changes
@Rubilmax Rubilmax dismissed their stale review January 19, 2024 10:29

test failing

QGarchery
QGarchery commented Jan 19, 2024
View reviewed changes
test/prod/ProdTest.sol Outdated Show resolved Hide resolved
@QGarchery QGarchery merged commit 9e7830a into main Jan 30, 2024
4 checks passed
@QGarchery QGarchery deleted the fix/upgrade-tests branch January 30, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD left review comments

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@QGarchery QGarchery

Labels
🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@QGarchery @Rubilmax @MerlinEgalite @MathisGD @Jean-Grimal