Monolithic checkpointing #3876
Merged
Monolithic checkpointing #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithwik-db
force-pushed
the
monolithic-checkpoiting
branch
2 times, most recently
from
5d9b3fc to
c26fa2d
Compare
rithwik-db
commented
Jun 13, 2025
rithwik-db
force-pushed
the
monolithic-checkpoiting
branch
from
c26fa2d to
465ad45
Compare
rithwik-db
force-pushed
the
monolithic-checkpoiting
branch
from
0fcbe52 to
1eeee6f
Compare
|
@bowenyang008 |
bowenyang008
approved these changes
Jun 26, 2025
WIP figured out where things are going wrong fixed some things formatted works? added comment some minor changes added some changes made some minor changes added some logging made another update undid previous change some more changes printing average of state checking difference before and after wrapping checking sync_module_states additional logging printing out valid params
rithwik-db
force-pushed
the
monolithic-checkpoiting
branch
from
1eeee6f to
3dedd6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added monolithic checkpointing for FSDP2
Tested test runs in this comment + added unit tests that check tied weights (although in general, tied modules is invalid and we raise an error for that)