Skip to content

Commit

Permalink
Change simulator UI help text to refer to directory
Browse files Browse the repository at this point in the history
When using the mode of the simulator in which you provide an existing
`index.json` file, the help text said to provide the absolute path to
the `index.json` file. However if you do so, the string `index.json` is
then appended to this leading to errors such as:

```
RuntimeError: No `remote` provided, but local file /home/scott/scratch/dummy-mds-dataset/index.json/index.json does not exist either
```

This PR changes the help text to instruct the user to provide the path
to the directory containing the `index.json` file, instead of to the
file itself.
  • Loading branch information
srstevenson committed Dec 9, 2024
1 parent a0d491e commit 13333da
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions simulation/interfaces/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ def stream_entry(component: DeltaGenerator,
on = component.toggle('use `index.json`', key=str(key) + 'toggle') if add_stream else None
if on or not add_stream:
path = component.text_input(
'path to `index.json`',
value='/absolute/path/to/index.json' if defaults is None else defaults['path'],
help='path to the `index.json` file for this stream. \
'path to directory containing `index.json`',
value='/absolute/path/to/dir/' if defaults is None else defaults['path'],
help='path to the directory containing the `index.json` file for this stream. \
the `index.json` file contains information about the shards in \
your dataset.',
key=str(key) + 'path',
Expand Down

0 comments on commit 13333da

Please sign in to comment.