This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Error if a Redis TLS url is specified #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s specified When using a managed Redis database, a `url` with `rediss://` is used for the Redis options, as supported by the latest `ioredis.` Currently with the legacy `ioredis` dependency, the `url` with `rediss://` option is ignored and the connection defaults silently to `localhost:6379.` The module may appear to work unintentionally if there is a localhost Redis. This proposed change will ensure that this module "fails early" and thereby reduce debugging time.
Strongbyte-ES
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a managed Redis database, a
urlwithrediss://is used for the Redis options, as supported by the latestioredis.Currently with the legacy
ioredisdependency, theurlwithrediss://option is ignored and the connection defaults silently tolocalhost:6379.The module may appear to work unintentionally if there is a localhost Redis.This proposed change will ensure that this module "fails early" and thereby reduce debugging time.
This change would have to be removed when the
ioredisdependency is upgraded e.g. to^4.14.1