[INJIMOB-1599]: Add spring cloud composite properties #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanth716
changed the title
swatigoel
suggested changes
Jul 25, 2024
| import io.micrometer.observation.ObservationRegistry; | ||
|
|
||
| @Configuration | ||
| public class compositeEnvironmentConfig { |
There was a problem hiding this comment.
class name should be CompositeEnvironmentConfig
| @Bean | ||
| public CompositeEnvironmentRepository compositeEnvironmentRepository() { | ||
| List<EnvironmentRepository> repositories = new ArrayList<>(); | ||
| JSONArray GitUrisArr = new JSONArray(gitUris); |
There was a problem hiding this comment.
Rename variable toconfigGitUris
| server: | ||
| port: 51000 | ||
| servlet: | ||
| context-path: ${server.servlet.path} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Spring Boot's configuration conventions, spring.profiles.active should not be defined in profile-specific property files like mimoto-default.properties
The spring.profiles.active property is defined in the mosip/inji-config mimoto-default.properties file.
Removing it from the file to get the congfigs from mosip/inji-config
SPRING_CONFIG_GIT_URISused in application.yml file is env variable.Value of this variable is json as stringify
"[{\"uri\": \"https://github.com/mosip/inji-config\", \"branch\": \"develop\"}, {\"uri\": \"https://github.com/mosip/mosip-config\", \"branch\": \"develop\"}]"