Builds with Go 1.18, but tests with 1.17, 1.18 and 1.19 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a test matrix to ensure the floor version of Mosn is two behind latest Go, even if one behind latest (currently 1.18) is used to build binaries. See mosn/mosn#2153 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
go-1.18
branch
from
9ba04b5
to
4ec68f9
Compare
codefromthecrypt
changed the title
|
cc @taoyuanyuan |
codefromthecrypt
commented
Nov 2, 2022
|
@taoyuanyuan ok! |
|
@codefromthecrypt Sorry for the delay. The test is failed, please take a look, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a test matrix to ensure the floor version of Mosn is two
behind latest Go, even if one behind latest (currently 1.18) is used to
build binaries.
See mosn/mosn#2153