ci: lint shell didn't reject imperfect script (#638)

Signed-off-by: spacewander <[email protected]>
mosn · Jul 11, 2024 · 4ca3fc5 · 4ca3fc5
1 parent e27e2f7
commit 4ca3fc5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -107,6 +107,7 @@ jobs:
         reporter: github-pr-review
         path: "."
         pattern: "*.sh"
+        fail_on_error: true
 
     - name: lint remain
       run: |

diff --git a/tools/gen-crd-code.sh b/tools/gen-crd-code.sh
@@ -21,8 +21,8 @@ readonly OUTPUT_PKG=${REPO}/types/pkg/client
 readonly APIS_PKG=${REPO}/types
 readonly CLIENTSET_NAME=versioned
 readonly CLIENTSET_PKG_NAME=clientset
-readonly GOPATH="$(mktemp -d)"
-readonly SCRIPT_ROOT="$(pwd)/types"
+GOPATH="$(mktemp -d)"
+SCRIPT_ROOT="$(pwd)/types"
 
 export GOPATH
 mkdir -p "$GOPATH/src/$REPO"
@@ -36,9 +36,11 @@ fi
 readonly COMMON_FLAGS="${VERIFY_FLAG:-} --go-header-file ${SCRIPT_ROOT}/hack/boilerplate.go.txt"
 
 echo "Generating clientset at ${OUTPUT_PKG}/${CLIENTSET_PKG_NAME}"
+# shellcheck disable=SC2086
 "${LOCALBIN}"/client-gen \
     --clientset-name "${CLIENTSET_NAME}" \
     --input-base "" \
     --input "${APIS_PKG}/apis/v1" \
     --output-package "${OUTPUT_PKG}/${CLIENTSET_PKG_NAME}" \
+    -v 3 \
     ${COMMON_FLAGS}