Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 增加对 aliyun oss 的支持||fix: Added support for Aliyun OSS #1069

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

EraserTime
Copy link
Contributor

@EraserTime EraserTime commented Sep 26, 2024

Github Action Bot detected the issue body's language is not English, translate it automatically

ListObjectsInput is added to fetch_owner indicates whether to obtain the owner information
The type of the Object in the ListObjectsOutput indicates the current state of the Object

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


原文 ListObjectsInput 增加 fetch_owner 表示是否获取 owner 信息 ListObjectsOutput 中 Object 增加 type 表示Object 当前的状态

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


```</details>
<!--MD5:bef15e21f15f74980323ce86abc6c832:MD5-->

   ListObjectsInput 增加 fetch_owner 表示是否获取 owner 信息
   ListObjectsOutput 中 Object 增加 type 表示Object 当前的状态
@zhenjunMa zhenjunMa changed the title 1、增加对 aliyun oss 的支持 1、增加对 aliyun oss 的支持||1. Added support for Aliyun OSS: Sep 26, 2024
Copy link

Hi @EraserTime. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@wenxuwan wenxuwan changed the title 1、增加对 aliyun oss 的支持||1. Added support for Aliyun OSS: feat:增加对 aliyun oss 的支持||1. Added support for Aliyun OSS: Sep 26, 2024
@zhenjunMa zhenjunMa changed the title feat:增加对 aliyun oss 的支持||1. Added support for Aliyun OSS: feat:增加对 aliyun oss 的支持||feat: added support for Aliyun OSS Sep 26, 2024
@wenxuwan
Copy link
Member

wenxuwan commented Sep 26, 2024

Github Action Bot detected the issue body's language is not English, translate it automatically

https://github.com/mosn/layotto/blob/main/pkg/grpc/extension/s3/s3.go#L414 If the input parameters from pb to component have conversion logic, they need to be added to the struct definition in the component

原文https://github.com/mosn/layotto/blob/main/pkg/grpc/extension/s3/s3.go#L414 pb到component的入参有转换逻辑的,需要在component里面的结构体定义里面也加上

@wenxuwan wenxuwan changed the title feat:增加对 aliyun oss 的支持||feat: added support for Aliyun OSS fix: 增加对 aliyun oss 的支持||feat: added support for Aliyun OSS Sep 26, 2024
@layotto-cla layotto-cla bot added the bug Something isn't working label Sep 26, 2024
@zhenjunMa zhenjunMa changed the title fix: 增加对 aliyun oss 的支持||feat: added support for Aliyun OSS fix: 增加对 aliyun oss 的支持||fix: Added support for Aliyun OSS Sep 26, 2024
@wenxuwan
Copy link
Member

wenxuwan commented Sep 27, 2024

Github Action Bot detected the issue body's language is not English, translate it automatically

please fix your ut
! [image] (https://github.com/user-attachments/assets/61cc8112-3644-44e0-86a5-2f57172bc586)

原文please fix your ut ![image](https://github.com/user-attachments/assets/61cc8112-3644-44e0-86a5-2f57172bc586)

@zhenjunMa zhenjunMa merged commit b4fed4d into mosn:main Sep 27, 2024
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants