Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates wazero to 1.2.1 #38

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

codefromthecrypt
Copy link
Contributor

This updates wazero to 1.2.1 which improves performance and support for non-blocking I/O.

goos: darwin
goarch: arm64
pkg: mosn.io/proxy-wasm-go-host/internal/e2e
                             │ v1.0.0-rc.2.txt │             v1.2.1.txt              │
                             │     sec/op      │    sec/op     vs base               │
StartABIContextV1_wazero-12       3.118m ±  8%   1.242m ±  4%  -60.15% (p=0.002 n=6)
AddRequestHeaderV1_wazero-12      3.751µ ±  3%   3.468µ ± 33%        ~ (p=0.065 n=6)
StartABIContextV2_wazero-12       3.345m ±  3%   1.375m ±  3%  -58.90% (p=0.002 n=6)
AddRequestHeaderV2_wazero-12      3.823µ ±  5%   5.038µ ± 26%  +31.79% (p=0.002 n=6)

This updates [wazero](https://wazero.io/) to [1.2.1](https://github.com/tetratelabs/wazero/releases/tag/v1.2.1) which improves performance and support for non-blocking I/O.

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Jun 26, 2023

note there is a lot of variance in the AddRequestHeaderXXX benchmark because the internal architecture of this plugin is not optimized.

An optimal plugin will re-use a module's function instances instead of re-creating them per request. This can get the performance more consistent. On the other hand, performance is limited anyway due to heavy use of reflection.

@doujiang24 doujiang24 merged commit 25a9e13 into mosn:main Jun 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants