630: Only nack messages upon cancellation of a consumer subscription … #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that belong to that consumer subscription.
|
Closes #630 |
|
Took awhile due to illness, vacation and other priorities. It also wasn't easy to find a proper, simple regression test, but I think I found one! Following TDD: The test was giving the expected exception before fixing the code. After fixing the code, the test succeeded. |
lfse-slafleur
commented
Jun 25, 2024
| @@ -1587,6 +1587,141 @@ async def test_heartbeat_disabling( | |||
| async with connection: | |||
| assert heartbeat == 0 | |||
|
|
|||
| async def test_non_acked_messages_are_redelivered_to_queue( | |||
There was a problem hiding this comment.
Test to see if messages are properly nack'ed and I didn't break anything.
lfse-slafleur
commented
Jun 25, 2024
| # Cleanup, delete the queue | ||
| await queue.delete() | ||
|
|
||
| async def test_regression_only_messages_cancelled_subscription_are_nacked( |
There was a problem hiding this comment.
Regression test which failed before fixing the code. Documentation is inline to show why the test is constructed the way it is.
lfse-slafleur
commented
Jun 25, 2024
mosquito
approved these changes
Jul 1, 2024
|
@lfse-slafleur released as 9.4.2 |
lfse-slafleur
deleted the
630-messages-are-nacked-multiple-times-around-queue-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that belong to that consumer subscription.