Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow
rocksdb.DB
instances to be manually closed
While `delete rocks_ptr` is a deterministic operation in C++, the Python analogue `del rocks_handle` is not – disposal and finalization of the Rocks database are entirely dependent on the Python garbage collector (q.v. the `python-rocksdb` tests themselves, which call `gc.collect()` after `del rocks_handle` to attempt to force the destructor to run). This change exposes a method to trigger the destruction of the underlying Rocks database pointer (deterministic!) through the Python Rocks handle; existing code will not need to be changed, as the Python object destructor (non-deterministic!) will now call this method. This is the second revision of this PR – it resolves the first revision, stephan-hof#39.
- Loading branch information