Skip to content

Commit

Permalink
Merge pull request duckdb#201 from jwills/jwills_disable_those_tests
Browse files Browse the repository at this point in the history
Disable these tests on MD and add a note to the README
  • Loading branch information
jwills authored Jun 29, 2023
2 parents e130be5 + e809368 commit 131f1e8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ there are a [few differences to be aware of](https://motherduck.com/docs/archite
1. MotherDuck databases do not suppport transactions, so there is a new `disable_transactions` profile
option that will be automatically enabled if you are connecting to a MotherDuck database in your `path`.
1. MotherDuck preloads a set of the most common DuckDB extensions for you, but does not support loading custom extensions or user-defined functions.
1. A small subset of advanced SQL features are currently unsupported; the only impact of this on the dbt adapter is that the [dbt.listagg](https://docs.getdbt.com/reference/dbt-jinja-functions/cross-database-macros#listagg) macro will work against a local DuckDB database, but will
not work against MotherDuck.
1. A small subset of advanced SQL features are currently unsupported; the only impact of this on the dbt adapter is that the [dbt.listagg](https://docs.getdbt.com/reference/dbt-jinja-functions/cross-database-macros#listagg) macro and foreign-key constraints will work against a local DuckDB database, but will not work against a MotherDuck database.

#### DuckDB Extensions, Settings, and Filesystems

Expand Down
5 changes: 5 additions & 0 deletions tests/functional/adapter/test_constraints.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,21 @@ class TestIncrementalConstraintsColumnsEqual(
pass


@pytest.mark.skip_profile("md")
class TestTableConstraintsRuntimeDdlEnforcement(
DuckDBColumnEqualSetup, BaseConstraintsRuntimeDdlEnforcement
):
pass


@pytest.mark.skip_profile("md")
class TestTableConstraintsRollback(DuckDBColumnEqualSetup, BaseConstraintsRollback):
@pytest.fixture(scope="class")
def expected_error_messages(self):
return ["NOT NULL constraint failed"]


@pytest.mark.skip_profile("md")
class TestIncrementalConstraintsRuntimeDdlEnforcement(
DuckDBColumnEqualSetup, BaseIncrementalConstraintsRuntimeDdlEnforcement
):
Expand All @@ -79,6 +82,7 @@ def expected_error_messages(self):
return ["NOT NULL constraint failed"]


@pytest.mark.skip_profile("md")
class TestIncrementalConstraintsRollback(
DuckDBColumnEqualSetup, BaseIncrementalConstraintsRollback
):
Expand All @@ -87,6 +91,7 @@ def expected_error_messages(self):
return ["NOT NULL constraint failed"]


@pytest.mark.skip_profile("md")
class TestModelConstraintsRuntimeEnforcement(
DuckDBColumnEqualSetup, BaseModelConstraintsRuntimeEnforcement
):
Expand Down

0 comments on commit 131f1e8

Please sign in to comment.