Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set up config check for connection validity #14

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Feb 12, 2024

Fivetran framework expects a list of connection tests to be returned from the ConfigurationForm endpoint. It will then call the Test endpoint in order for each of the tests specified.

Given that the token is already a required property on the Fivetran side, for the MotherDuck destination there is only one useful check -- "can the user authenticate?". The check already existed, but it was not making use of the TestRequest.name() field.

I thought about making an unknown test name log a warning and succeed, but this will just hide potential integration problems, so I ended up making it an error instead.

Fixes #5

For reference, here is an example of configuration tests for a Github source:
Screenshot from 2024-02-12 08-57-22

@elefeint elefeint requested a review from guenp February 12, 2024 14:30
Copy link
Member

@guenp guenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just had one suggestion

src/motherduck_destination_server.cpp Outdated Show resolved Hide resolved
@elefeint elefeint merged commit c673607 into main Feb 15, 2024
1 check passed
@elefeint elefeint deleted the add_config_tests branch February 15, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ConfigurationTest for validations
2 participants