Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make it work:
old_implicit_casting
is required to load staged varchar data into typed columns; otherwise 0.10.2 runs intoduckdb::DBConfig
constructor changed, so I added properties one by one instead of preconstructing the map.The test had a hardcoded database name, which for me is now, of course, readonly in 0.10 mode, so I refactored to make it easier to change the database name.