Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to DuckDB 0.10.2 #39

Merged
merged 1 commit into from
May 9, 2024
Merged

Upgrade to DuckDB 0.10.2 #39

merged 1 commit into from
May 9, 2024

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented May 9, 2024

Changes to make it work:

  1. Fivetran batch files contain VARCHAR values in columns of all types to denote "null" and "do not modify this" values.
    old_implicit_casting is required to load staged varchar data into typed columns; otherwise 0.10.2 runs into
Cannot mix values of type VARCHAR and
  INTEGER in CASE expression - an explicit cast is required
  1. duckdb::DBConfig constructor changed, so I added properties one by one instead of preconstructing the map.

  2. The test had a hardcoded database name, which for me is now, of course, readonly in 0.10 mode, so I refactored to make it easier to change the database name.

@elefeint elefeint requested a review from guenp May 9, 2024 18:07
@elefeint elefeint merged commit 282ad51 into main May 9, 2024
1 check passed
@elefeint elefeint deleted the upgrade-duckdb-0.10.2 branch May 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants