Make CSV block size configurable. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elefeint
commented
Jul 1, 2024
| auto parse_options = arrow::csv::ParseOptions::Defaults(); | ||
| auto convert_options = get_arrow_convert_options(utf8_columns, null_value); | ||
| parse_options.newlines_in_values = true; |
There was a problem hiding this comment.
sneaking this setting in since it came up in my testing, and I don't see why you'd ever want this to be off.
hrl20
approved these changes
Jul 1, 2024
| auto msg = "Authentication test for database <" + db_name + | ||
| "> failed: " + std::string(e.what()); | ||
| auto msg = | ||
| "Test for database <" + db_name + "> failed: " + std::string(e.what()); |
There was a problem hiding this comment.
maybe include the test name in msg
| } | ||
|
|
||
| { | ||
| // succeed when block_size is increased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default block size in Arrow CSV reader is 1MB (or so?). This PR makes it configurable in multiples of a megabyte.
Fixes ECO-142