Check for optional field presence before using them #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awitten1
reviewed
Aug 16, 2024
| @@ -15,6 +15,10 @@ static constexpr const char *const CONFIG_TEST_NAME_AUTHENTICATE = | |||
| static constexpr const char *const CONFIG_TEST_NAME_CSV_BLOCK_SIZE = | |||
| "test_csv_block_size"; | |||
|
|
|||
| static const int DUCKDB_DEFAULT_PRECISION = 18; | |||
|
|
|||
| static const int DUCKDB_DEFAULT_SCALE = 3; | |||
There was a problem hiding this comment.
Nit: this should probably be in the cpp file. Otherwise we'll actually have multiple copies of these constants in every cpp file that includes this one.
There was a problem hiding this comment.
won't #pragma once prevent that?
awitten1
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually had tests for the hard-delete scenario, but the thing with invalid memory access is that it's invalid in different ways...
This is likely what's causing the segfault for fivetran_log and github connectors.