-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve trip display name #174
base: master
Are you sure you want to change the base?
Conversation
Also I don't really understand this block just before, for me this isn't need as just the logic route short name > route long should be used. nigiri/src/loader/gtfs/trip.cc Lines 230 to 244 in 98c239b
|
[=](std::string_view line_id) { | ||
return !is_digit(line_id.front()) && is_digit(line_id.back()); | ||
}; | ||
auto precedence = std::array{std::string_view{route_->short_name_}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for all feeds that use semantic naming instead of the google maps convention.
That is as far as I know most of the data for Germany and Austria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly doesn't work, not prefering trip short name?
Do you have any specific example in mind?
This should improve the trip short name in the UK, and also for RER in Paris (France). |
Related to public-transport/transitous#886