Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist - gather coordinates for one to many routing #155

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

nilspenzel
Copy link
Contributor

No description provided.

Copy link
Member

@felixguendling felixguendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugfix + tests

@@ -2,7 +2,7 @@ import type { BusStop } from './busStop';
import type { Capacities } from './capacities';
import type { Coordinates } from './location';

export type BookingRequestParameters = {
export type CheckBookingValidityParameters = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type CheckBookingValidityParameters = {
export type WhiteListRequest = {

Man kann dann BlackListRequest als Alias von Whitelist Request definieren.

Terminologie für Anfragen = ...Request
Terminologie für Antworten = ...Response (ggf. hier wieder Typalias BlacklistResponse = WhitelistResponse falls zutreffend

Comment on lines 7 to 8
busStopCompanyFilter: boolean[][],
insertions: Map<number, Range[]>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was ist die Semantik von boolean[][] und number und Range?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants