Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AdditionalMetadata config #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adding AdditionalMetadata config #3

wants to merge 6 commits into from

Conversation

guidoPeirano
Copy link
Collaborator

Description

Pre-merge author checklist

  • A brief description of the protocol and adapters is added to the PR
  • Files outside the protocol folder are not being edited and, if they are, it's clearly explained why in the PR
  • update me comments are removed
  • Contracts used are verified for that chain block explorer
  • Test cases with a block number have been added to the testCases.ts file for every relevant method that has been implemented
    • positions
    • profits
    • prices (unwrap)
    • deposits
    • withdrawals
    • repays
    • borrows
    • tvl
  • getAddress from ethers
    • Is used to parse hardcoded addresses
    • Is used to parse addresses that come from contract calls when it is not clear they'll be in checksum format
    • It is NOT used to parse addresses from input methods
    • It is NOT used to parse addresses from metadata
  • For every adapter that extends SimplePoolAdapter
    • getPositions is not overwritten and, if it is, it's clearly explained why in the PR
    • unwrap is not overwritten and, if it is, it's clearly explained why in the PR
  • If the adapters requires to fetch static data on-chain (e.g. pool ids, token metadata, etc)
    • The adapter implements IMetadataBuilder
    • The buildMetadata method is implemented with the @CacheToFile decorator
    • All the static data is stored within the metadata JSON file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guidoPeirano