Validate enumerations. #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I considered adding a way to turn this off as working validation might surprise people but decided against it. |
|
@bknotwell could you please take a look at why the CI fails, and (hopefully) remedy it? Thanks! |
|
@bknotwell ping? |
|
@bknotwell thank you for the contribution - but are you planning to fix the CI failures? |
@bknotwell i can't afford merging a PR that breaks validation. Could you fix it, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a fan of the way I threaded state through with the localvalidation member but I don't have a better idea. I added it as a union to make it easier to reuse it for other use cases.