add method and test webinar report #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanRFerguson
approved these changes
Dec 13, 2024
parsons/zoom/zoom.py
Outdated
| @@ -40,7 +40,7 @@ def __init__(self, account_id=None, client_id=None, client_secret=None): | |||
| authorization_kwargs={"account_id": self.account_id}, | |||
| ) | |||
|
|
|||
| def _get_request(self, endpoint, data_key, params=None, **kwargs): | |||
| def _get_request(self, endpoint, data_key=None, params=None, **kwargs): | |||
There was a problem hiding this comment.
what's the rationale behind defaulting this to None type?
There was a problem hiding this comment.
This method that I have returns data that doesn't need to be parsed further using a key.
There was a problem hiding this comment.
But I guess it doesn't necessarily need to be a default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get_webinar_report method to zoom connector