Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ros2 branch of moveit_task_constructor instead of humble #721

Closed
wants to merge 2 commits into from

Conversation

lukas-jung
Copy link

Description

The humble branch has been removed.
See moveit/moveit_task_constructor#480

sea-bass
sea-bass previously approved these changes Jul 30, 2023
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sea-bass
Copy link
Contributor

Ah, a few more updates are needed here due to renamed variables in MTC. I can take a look later if someone doesn't get to it first.

@sea-bass sea-bass dismissed their stale review July 30, 2023 13:18

Source code changes needed

@rhaschke
Copy link
Contributor

Looks like deleting the humble branch in MTC was a mistake. As the ros2 branch ran successfully with the docker image humble-source (moveit/moveit_task_constructor#470), I thought that the humble branch wouldn't be necessary anymore. However, it is for use with the MoveIt humble branch used for the image humble-release, which is used here.
@ros-planning/moveit-core-contributors, does any maintainer still have the humble branch locally to restore it?
This would avoid redoing the humble modifications...

@sea-bass
Copy link
Contributor

sea-bass commented Jul 30, 2023

@rhaschke I didn't have it locally, but I just pushed a slightly modified version of the ros2 branch to humble that compiles and runs for me against moveit2_tutorials. Please check it:

https://github.com/ros-planning/moveit_task_constructor/tree/humble

EDIT: Of course, if someone else does have the actual old version of the humble branch handy, feel free to change this.

@sea-bass
Copy link
Contributor

NOTE: I found a separate issue in humble that requires this backport: #722

@rhaschke
Copy link
Contributor

Thanks, @sea-bass. I did the same in parallel and also added a CI build for humble-release. Closing this PR as obsolete.

@rhaschke rhaschke closed this Jul 30, 2023
@lukas-jung
Copy link
Author

@sea-bass @rhaschke

The commits of the original humble branch still exist:
293898690e323176c0f5c2fbe223affa53bde462

This is HEAD of my local copy. Cloned July 24.

It might be helpful for users if the new version is rebased to the old version so they can update it with git pull.

@rhaschke
Copy link
Contributor

@lukas-jung, you should be able to fast-forward from the specified commit to the new humble branch:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants