Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced deprecated functions to reduce warnings during build #726

Merged
merged 9 commits into from
Aug 18, 2023
Merged

Replaced deprecated functions to reduce warnings during build #726

merged 9 commits into from
Aug 18, 2023

Conversation

Shobuj-Paul
Copy link
Contributor

@Shobuj-Paul Shobuj-Paul commented Jul 31, 2023 •
edited
Loading

Description

Replaced the following deprecated functions to reduce warnings during build.

  • Replaced setMaxVelocityScaling() with setMaxVelocityScalingFactor().
  • Replaced setMaxAccelerationScaling() with setMaxAccelerationScalingFactor().

Fixes #725

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

sea-bass
sea-bass requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can you also modify the corresponding .rst files in doc/tutorials/pick_and_place_with_moveit_task_constructor/pick_and_place_with_moveit_task_constructor.rst?

@sea-bass sea-bass added the backport-humble This label signals Mergify to backport this PR to Humble label Jul 31, 2023
@sea-bass
Copy link
Contributor

I think GitHub is being weird. I saw the email notification for the follow-up commit but it doesn't show up on here. Will check later.

@Shobuj-Paul
Copy link
Contributor Author

I think GitHub is being weird. I saw the email notification for the follow-up commit but it doesn't show up on here. Will check later.

Yep, commit showed up on the branch but not here. Maybe just some delay.

@Shobuj-Paul
Copy link
Contributor Author

Hi @sea-bass
Check now please, the docs have also been updated.

@sjahr sjahr merged commit 5f651f0 into moveit:main Aug 18, 2023
9 checks passed
mergify bot pushed a commit that referenced this pull request Aug 18, 2023
@Shobuj-Paul @mergify
Replaced deprecated functions to reduce warnings during build (#726)
2a5ce9a 
* Replaced deprecated functions to reduce warnings during build

* updated .rst file in docs

* GitHub issue

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit 5f651f0)
@mergify mergify bot mentioned this pull request Aug 18, 2023
Merged
@Shobuj-Paul Shobuj-Paul deleted the deprecated_scaling_functions branch August 18, 2023 11:00
sjahr pushed a commit that referenced this pull request Aug 18, 2023
@mergify @Shobuj-Paul
Replaced deprecated functions to reduce warnings during build (#726) (#…
cb1b9b6 
…753)

* Replaced deprecated functions to reduce warnings during build

* updated .rst file in docs

* GitHub issue

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit 5f651f0)

Co-authored-by: Shobuj Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

@sea-bass sea-bass sea-bass approved these changes

Assignees
No one assigned
Labels
backport-humble This label signals Mergify to backport this PR to Humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning due to deprecated functions
3 participants
@Shobuj-Paul @sea-bass @sjahr