-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Servo] Update servo tutorials #734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
Tutorials are in good shape -- my only major suggestion here is that for this repo we don't directly link to code using its URL, and instead there are all these handy RST directives to help link code while keeping things in sync with different versions.
Besides that, mostly editorial stuff.
0a0bf0b
to
41400e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now, and the source code updates are needed to make the tutorials build on main anyhow, so let's go for it!
Thank you for updating this! |
Description
This PR updates the tutorials for MoveIt Servo as part the recent refactor moveit/moveit2#2224.
Checklist
Pining @sea-bass @AndyZe for review.