Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clamping of joint constraint in MoveRelative stage #665

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

captain-yoshi
Copy link
Contributor

@captain-yoshi captain-yoshi commented Feb 24, 2025

Fixes #664. Do not enforce position bounds, let the stage fail if joints are outside the limits instead of clamping to valid positions.

There are maybe some who would actually want to move relative up to the position limit. But there's a lot chances that this will fail in subsequent stages.

Do not enforce position bounds, let the stage fail if joints are
outside the limits instead of clamping to valid positions.
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.04%. Comparing base (bad8e13) to head (f9930dd).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   59.07%   59.04%   -0.02%     
==========================================
  Files          97       97              
  Lines        9004     9003       -1     
==========================================
- Hits         5318     5315       -3     
- Misses       3686     3688       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the PR.

@rhaschke rhaschke merged commit a0da41a into moveit:master Feb 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not enforce position bounds for a joint MoveRelative
3 participants