Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: installer #115 #105. #117

Merged
merged 2 commits into from
Mar 1, 2024
Merged

fix: installer #115 #105. #117

merged 2 commits into from
Mar 1, 2024

Conversation

l-monninger
Copy link
Collaborator

Pull Request

Description

  • This contribution represents a trivial change (skip the following sections).
  • This contribution represents a CI/CD change that needs to be tested e2e (skip the following sections; justify below).
  • Stop the installer from blocking installations via --build for non-Linux platforms.
  • Strips out vestigial logic for some dependency management which is now handled by movement ctl manage.
  • Renovates build dependency logic.

Motivation and Context

#115 and #105

Changes Made

  • Stop the installer from blocking installations via --build for non-Linux platforms.
  • Strips out vestigial logic for some dependency management which is now handled by movement ctl manage.
  • Renovates build dependency logic.

Testing

I've tested manually and locally on MacOS Arm64 (M1) and in containers for Linux x86_64 and Linux Arm64.

Screenshots (if applicable)

Related Issues

Checklist

  • I have read and followed the project's contributing guidelines.
  • I have tested the changes thoroughly.
  • My code follows the style and formatting guidelines of the project.
  • I have updated the relevant documentation, if applicable.
  • I have added tests, if appropriate.
  • The code builds without any errors or warnings.
  • All existing tests pass successfully.

Additional Notes

@l-monninger l-monninger merged commit af5ae1d into dev Mar 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant