Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the
governed_gas_pool
designed in MIP-52 to theaptos_framework
. When the featureGOVERNED_GAS_POOL
is enabled, the transaction epilogue will deposit gas fees into the pool.Outstanding
spec
needs to be updated both forFA
(something Aptos had not yet done) and governed gas pool usage. Or else new tests need to be configured which do not yet have a template.transaction_validation.spec.move
. However, this should likely be implemented intransaction_fee.spec.move
instead.governed_gas_pool
w.r.t to epoch boundaries needs to validated in the corresponding full node PR.governed_gas_pool
feature path does not account or allow for any net positive transactions as is clear in the flow control intransaction_validation.move
. Whether this is appropriate still needs to be validated.