Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governed Gas Pool #114

Draft
wants to merge 5 commits into
base: movement
Choose a base branch
from
Draft

Conversation

l-monninger
Copy link
Collaborator

@l-monninger l-monninger commented Dec 16, 2024

Summary

Introduces the governed_gas_pool designed in MIP-52 to the aptos_framework. When the feature GOVERNED_GAS_POOL is enabled, the transaction epilogue will deposit gas fees into the pool.

Outstanding

  1. The spec needs to be updated both for FA (something Aptos had not yet done) and governed gas pool usage. Or else new tests need to be configured which do not yet have a template.
  2. The use of the governed_gas_pool w.r.t to epoch boundaries needs to validated in the corresponding full node PR.
  3. The governed_gas_pool feature path does not account or allow for any net positive transactions as is clear in the flow control in transaction_validation.move. Whether this is appropriate still needs to be validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant