Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
aptos-move/e2e-move-tests/src/tests/bridge.rs
:test_counterparty
so anyone with the pre-image can callatomic_bridge_counterparty::complete_bridge_transfer
test_initiator
so initiator callsatomic_bridge_initiator::complete_bridge_transfer
test_refund
andtest_abort
In
aptos-move/framework/aptos-framework/sources/atomic_bridge.move
:assert_is_caller_operator(caller);
fromatomic_bridge_initiator::complete_bridge_transfer
(see the correspondingfun
in our audited module: https://github.com/movementlabsxyz/movement/blob/main/protocol-units/bridge/move-modules/sources/atomic_bridge_initiator.move)test_complete_bridge_transfer_by_sender
test_complete_bridge_transfer_timelock_expired
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
movement move test
cargo test bridge
Key Areas to Review
atomic_bridge_initiator::complete_bridge_transfer
, then we should update our audited modules. However, I don't see why it would be an issue, if the counterparty lock and abort calls are restricted to the operator.Checklist