Gas Fee for Validation Only #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
requested changes
Nov 6, 2024
| Self { | ||
| // todo: ideally this would be set by governance, which means adjusting `unwrap_or_discard` to accept some kind of reference and provide it here. | ||
| // this is currently based on base gas: https://aptos.dev/en/network/blockchain/base-gas | ||
| total_charge_gas_units: std::env::var("APTOS_BASE_GAS_UNITS") |
There was a problem hiding this comment.
Would it be a bit wasteful to query environment every time VMOutput::empty_with_status() is called somewhere deep in the code?
Comment on lines
+57
to
+59
| .unwrap_or("2_100_000".to_string()) | ||
| .parse() | ||
| .unwrap_or(2_000_000), |
There was a problem hiding this comment.
There should be just one source of truth on the default value, so if env::var fails, the default literal value should be used instead. Parsing fixed strings feels a bit like a daft code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a gas fee charge for validation and other discarded transactions. This is intended to address movementlabsxyz/movement#490
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Identify the relationship between the
FeeStatement,unwrap_or_discard, and the actual gas charged inVMOutput.Checklist