vscode-ext: fix flickering view rendering after server restart #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp15b
requested changes
May 31, 2024
vscode-ext/src/CaesarClient.ts
Outdated
| @@ -113,6 +113,17 @@ export class CaesarClient { | |||
| this.needsRestart = true; | |||
| } | |||
| })); | |||
|
|
|||
| // listen to onDidSaveTextDocument events | |||
| const autoVerify: string = CaesarConfig.get(ConfigurationConstants.automaticVerification); | |||
There was a problem hiding this comment.
This will only check the automatic verification setting once when the extension is loaded, as opposed to every time the server is reloaded (which happens when the config changes). I have two options: a) just save the Disposable from onDidSaveTextDocument and dispose of the callback when the server is stopped, or b) do the check inside the callback (but then check for languageId first, only then do the config check).
Philipp15b
approved these changes
Jun 4, 2024
|
Thanks! |
Philipp15b
added a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the flickering bug which occurs when the server is restarted multiple times.
Cause: The$n$ times, the same $n$ times when the document is saved. this makes the server verify the same document $n$ times consecutively which ultimately causes the flickering of the view elements.
startmethod of the client calls thecreateClientmethod, which registered theonDidSaveTextDocumentcallback. Hence every restart registers a copy of the same callback. Therefore if the server is restartedonDidSaveTextDocumentcallback is being calledFix: The
onDidSaveTextDocumentcallback register is moved to theCaesarClients constructor (where also command callbacks are registered) instead of thecreateClientmethod