Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Expand-Archive): import it from Microsoft.PowerShell.Archive module #350

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

zjp-CN
Copy link

@zjp-CN zjp-CN commented Jan 18, 2025

For PowerShell 5.1, Expand-Archive default from Pscx module uses -OutputPath instead of -DestinationPath parameter.

Downloading WasmEdge 0.14.0 from GitHub; installing to C:\Users\Administrator\AppData\Roaming\moxin-org\moly\data\WasmEdge-0.14.0-Windows
 --> Using WASI-NN plugin at: https://github.com/second-state/WASI-NN-GGML-PLUGIN-REGISTRY/releases/download/b3499/WasmEdge-plugin-wasi_nn-ggml
-noavx-0.14.0-windows_x86_64.zip
Successfully installed wasmedge to: C:\Users\Administrator\AppData\Roaming\moxin-org\moly\data\WasmEdge-0.14.0-Windows
thread 'main' panicked at moly-runner\src\main.rs:242:10:
failed to find or install wasmedge dylibs

Also see: PowerShell/Microsoft.PowerShell.Archive#52


It's odd that the result of powershell_script run is Ok (i.e. output.success() is true) for the whole ps script. I wrote a unit test using Expand-Archive with -DestinationPath, the result is Err and the same InvalidArgument output as I saw from the ps prompt.

For PowerShell 5.1, Expand-Archive default from Pscx module use -OutputPath
instead of -DestinationPath parameter.

```
Downloading WasmEdge 0.14.0 from GitHub; installing to C:\Users\Administrator\AppData\Roaming\moxin-org\moly\data\WasmEdge-0.14.0-Windows
 --> Using WASI-NN plugin at: https://github.com/second-state/WASI-NN-GGML-PLUGIN-REGISTRY/releases/download/b3499/WasmEdge-plugin-wasi_nn-ggml
-noavx-0.14.0-windows_x86_64.zip
Successfully installed wasmedge to: C:\Users\Administrator\AppData\Roaming\moxin-org\moly\data\WasmEdge-0.14.0-Windows
thread 'main' panicked at moly-runner\src\main.rs:242:10:
failed to find or install wasmedge dylibs
```

Also see: PowerShell/Microsoft.PowerShell.Archive#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant