Prompt example #357
Draft
Prompt example #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main update 27 Set
Main update 2 Oct
Fix the file name in release CI
Use a personal access token to upload release
Main update 10 Oct
Main update 20 nov
alanpoon
reviewed
Feb 1, 2025
Comment on lines
+504
to
+505
| // Read a file from JSON. | ||
| let file_content = fs::read_to_string("./resources/files/prompt_data.json").expect("Failed to read JSON file"); |
There was a problem hiding this comment.
You should not be doing computation expensive operation here in the draw_walk as draw_walk runs multiple times.
There was a problem hiding this comment.
Thanks for your review! I noticed that, and I'll fix it in future commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.