Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 1218415 - [Messages][Tests] Add the "delete selected messages" integration test to "Conversation Edit Mode" suite #33384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug 1218415 - [Messages][Tests] Add the "delete selected messages" integration test to "Conversation Edit Mode" suite #33384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c1ddd3
[1,2] done
TheShadow29 Nov 26, 2015
3052e85
[12] done
TheShadow29 Nov 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/sms/test/marionette/conversation_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,18 @@ marionette('Conversation Panel Tests', function() {
'4 selected',
'Edit mode header should show correct number of messages'
);
test('User selects some messages ,deletes them',function(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Don't keep commas in the test message, Space after comma please, Space after ) please

conversationView.enterEditMode();
var messageIndicesToSelect = [2,0];
var messages = conversationView.messages();

messageIndicesToSelect.forEach(function(messageIndex){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Space after ) please

conversationView.tapOnMessage(mesages[messageIndex].id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have probably misspelled messages. The code won't compile :)
Missing ;

});


})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ;


});
});
});
Expand Down