Prepare release 1.10 #220
Merged
Prepare release 1.10 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcottner
reviewed
May 29, 2024
| @@ -3,8 +3,8 @@ | |||
| "[email protected]": { | |||
| "updates": [ | |||
| { | |||
| "version": "1.9.0buildid20240422.103808", | |||
| "update_link": "https://github.com/mozilla-extensions/remote-settings-devtools/releases/download/1.9.0-build1/remote-settings-devtools.xpi" | |||
| "version": "1.10.0_TBD", | |||
There was a problem hiding this comment.
Why _TBD in the version string here? We didn't do that in the past.
There was a problem hiding this comment.
As I wrote elsewhere, note for future readers:
The addon update mechanism will fetch this file. Its URL is specified here in the addon manifest:
The problem is that we can't know this version string in advance. It is set by Taskcluster when the final .xpi is signed. So, instead of setting it to something that looks final like I did in the past, I thought it would make it clearer that we need a PR like this one once the .xpi is going to be published
alexcottner
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.