Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate alternate solutions for template params #6

Closed
escapewindow opened this issue Apr 22, 2020 · 1 comment
Closed

investigate alternate solutions for template params #6

escapewindow opened this issue Apr 22, 2020 · 1 comment

Comments

@escapewindow
Copy link
Contributor

I initially put these in to give us debugging information about which revision of the template repo we used in a given graph. Per this thread, we may want to adjust this.

We probably want to weigh the effort of doing so with the likelihood of wanting to reuse this code. I think mozilla-extensions is a special use case, and we may not need generic support for this.
@escapewindow escapewindow mentioned this issue Apr 22, 2020
Merged
@escapewindow
Copy link
Contributor Author

Looks like we get a TinderboxPrint with the revision in the decision log. That's sufficient for our purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@escapewindow