Shared tc dir #5
Conversation
Uh oh! Looks like an error! DetailsInterpreterError at template.tasks[0].payload.env[0]["GITHUB_CLONE_SECRET"]: unknown context value githubCloneSecret |
2 similar comments
Uh oh! Looks like an error! DetailsInterpreterError at template.tasks[0].payload.env[0]["GITHUB_CLONE_SECRET"]: unknown context value githubCloneSecret |
Uh oh! Looks like an error! DetailsInterpreterError at template.tasks[0].payload.env[0]["GITHUB_CLONE_SECRET"]: unknown context value githubCloneSecret |
| @@ -213,10 +229,14 @@ tasks: | |||
| then: > | |||
| PIP_IGNORE_INSTALLED=0 pip install --user /builds/worker/checkouts/taskgraph && | |||
| cd /builds/worker/checkouts/src && | |||
| rm -rf taskcluster && | |||
| ln -s /builds/worker/checkouts/template/taskcluster taskcluster && | |||
There was a problem hiding this comment.
You should not need to do this dance moving around the taskcluster directory. You can pass --root path/to/taskcluster/ci to taskgraph decision to read from a different location (this is how comm-central handles things).
Alternatively, you could run taskgraph from the template repository, with the xpi repository in a known place. (This is closer to what ci-admin/ci-config does, but ci-config isn't even checked out).
There was a problem hiding this comment.
Looks like this breaks any automation on xpi-template itself, but perhaps we want to turn that off anyway?
There was a problem hiding this comment.
Looks like it breaks for test-xpi-public as well. I'm guessing --root also keeps us from looking in test-xpi-public for the xpi source, and instead looks in xpi-template ?
There was a problem hiding this comment.
Alternatively, you could run taskgraph from the template repository, with the xpi repository in a known place. (This is closer to what ci-admin/ci-config does, but ci-config isn't even checked out).
I think I was avoiding this, because a) we need to translate paths, and b) xpi-template is level 3; the xpi source repo will be level 1. We could make xpi-template level 1. Is going back to the taskcluster/ dance a blocker?
There was a problem hiding this comment.
busted test-xpi-public: mozilla-releng/staging-xpi-public#6
There was a problem hiding this comment.
--root seems to break everything. I'm going to punt on that.
|
@tomprince better? I'm punting on @rail I can merge as admin, but we may want a real approving review. |
taskcluster/docker/REGISTRY
Outdated
| @@ -0,0 +1 @@ | |||
| mozilla-mobile | |||
There was a problem hiding this comment.
| mozilla-mobile | |
| mozilla-extensions |
There was a problem hiding this comment.
It looks like these two comments are regarding the xpi-manifest repository. I'll open a PR there to address these.
There was a problem hiding this comment.
taskcluster/docker/base/Dockerfile
Outdated
|
|
||
| FROM ubuntu:18.04 | ||
|
|
||
| MAINTAINER Tom Prince "[email protected]" |
There was a problem hiding this comment.
This should probably be updated (or removed, I'm not sure how much value it is providing).
There was a problem hiding this comment.
mozilla-extensions/xpi-manifest#32 . (The tip of this PR doesn't have any taskcluster/docker; we use the docker image indexes from xpi-manifest. I tried copying the docker directory as part of trying to resolve the --root bustage.)
|
Thanks! I'll merge this and update docs. |
This is an attempt to share
taskcluster/for all xpi source repos. We do need to copy in.taskcluster.ymlinto the source repo for things to work.@tomprince how does this look? mozilla-releng/staging-xpi-public#6 is an example of a project using this.