Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate alternate solutions for the taskcluster directory #7

Open
escapewindow opened this issue Apr 22, 2020 · 1 comment
Open

Comments

@escapewindow
Copy link
Contributor

Things work the smoothest by nuking and linking the xpi-template taskcluster/ directory into the xpi source dir. There are potentially other options as mentioned in this thread.

I'm avoiding doing so because:

  • using --root implies the source is in the xpi-template directory, which breaks
  • we could also run in the xpi-template directory (with or without --root), and specify a known location for the xpi source.
    • I believe this will reuse the level from the xpi-template repo instead of the source repo. I'm intentionally keeping xpi-template level 3 and the source repos level 1, to reflect the amount of trust given to each repo. I'd rather not treat the source repos as level 3, or treat the xpi-template repo as level 1, since we want to restrict what changes go into the template repo.

Opening this to track investigating other solutions, or revisit the above reasoning.

@tomprince
Copy link

* using `--root` implies the source is in the xpi-template directory, which breaks

I haven't looked at all the test failures, but the one I looked it, it appears that various bits of the docker support code assumes that docker images are in the current directory, under taskcluster/docker. This did not affect comm-central, since it was re-using the m-c images, so that was correct. This is definitely something we can address, by passing down the correct directory to taskgraph.util.docker in various places.

* we could also run in the xpi-template directory (with or without `--root`), and specify a known location for the xpi source.

This is how ci-config works with ci-admin (ci-config is checked out in config/).

  * I believe this will reuse the level from the xpi-template repo instead of the source repo

The level should come entirely from the arguments to taskgraph decision, which comes from .taskgraph.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants