Add loading status, fix spinner, fix back-button issue #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This lets spinner stay in view while autologging in - It adds text to show what we're autologging in with, and sends that as part of GA event - It redirects with `window.location.replace` which does not leave an entry in the user's browser history, so no back button issue Signed-off-by: Hidde de Vries <[email protected]>
Signed-off-by: Hidde de Vries <[email protected]>
hidde
changed the title
hidde
changed the title
andrewkrug
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.location.replacewhich does not leave an entry in the user's browser history, so no back button issue (fixes the NLX part of #229)Signed-off-by: Hidde de Vries [email protected]