Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp #462

Merged
merged 141 commits into from
Jul 11, 2023
Merged

Revamp #462

merged 141 commits into from
Jul 11, 2023

Conversation

dividehex
Copy link
Contributor

This is a major rework of the SSO Dashboard primarily to migrate it to GCP but also clean up the repo.

@dividehex
Remove Prometheus usage
09882fe
@dividehex
Remove Credstash
2e0a4af
@dividehex
Update requirements.txt
1905f2c
@dividehex
Update gitignore
7cefb29
@dividehex
Remove unused files
98796b8
@dividehex
Relocate old ansible files
5b9e3ba
@dividehex
Remove aws logging
30ea743
@dividehex
Redo Dockerfile
a3a0380
@dividehex
Load config from environment variables
6015e2e
@dividehex
Github Actions to deploy
2110722
@dividehex
Rename github action workflow
ea54520
@dividehex
Trigger action in this dev branch
be3351c
@dividehex
Docker auth in GHA
f76e143
@dividehex
GHA build and push docker
bd235df
@dividehex
Update certifi and dataclasses pip packages
dea6a3a
@dividehex
GHA clouddeploy templates
cb39abb
@dividehex
Allow unauthenticated logout route
b033b33
@dividehex
Revert "Allow unauthenticated logout route"
4520883 
This reverts commit b033b33.
@dividehex
Major package dependancy updates
580180d
@dividehex
Fix requirements.txt
e246c3f
@dividehex
Clean up requirements.txt and pin updated packages
2161337
@dividehex
More package dependency changes
65073d9
@dividehex
Add missing cssmin package
9f70a94
@dividehex
Clean up dockerfile and add missing python deps
dbc3859
@dividehex
Use nodejs sass instead of ruby sass
15a37b4
@dividehex
Add missing jsmin dep
682335d
@dividehex
Return apps.yml to a skel file
dad66b4
@dividehex
Add deployment to GHA
0c911bd
@dividehex
Change clouddeploy templates
cf76ddc
@dividehex
Fix path to skaffold file
78f18b4
floatingatoll
floatingatoll approved these changes Jun 21, 2023
View reviewed changes
Copy link

@floatingatoll floatingatoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in staging with the two caveats discussed at the presentation a week or so ago, and no one else is developing on this, so as reviewer of last resort: yup, I think it's valid code that works.

gcoxmoz
gcoxmoz approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@gcoxmoz gcoxmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way I can give this a cromulent review, but my skim says that this is in line with things Jake's talked about and shown, and I see no reason to hold this up.

@dividehex dividehex merged commit 0c82d56 into master Jul 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floatingatoll floatingatoll floatingatoll approved these changes

@gcoxmoz gcoxmoz gcoxmoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dividehex @floatingatoll @gcoxmoz