Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Min/Max cloud run instances #520

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Increase Min/Max cloud run instances #520

merged 1 commit into from
Aug 21, 2024

Conversation

dividehex
Copy link
Contributor

    Recently, the Min/Max cloud run instances had been reduced in
    an attempt to fix the failure causing the stale apps.yml data.
    This commit increases the min instances to 1 for dev and 2 for
    staging and prod.  The max is set to 3 for all 3 environments.

    This also adjusts the gunicorn async workers to 3 which is based
    on the fact, instances for all environments are set to 1vCpu.
    Where n = vCpus, we get 2n + 1 as a basis for setting the
    workers.  This can be adjust in the future if we ever change the
    number of vCpus per instance.

    Other things:
    * Remove some unused ENVs
    * Remove max-requests and max-requests-jitter

        Recently, the Min/Max cloud run instances had been reduced in
        an attempt to fix the failure causing the stale apps.yml data.
        This commit increases the min instances to 1 for dev and 2 for
        staging and prod.  The max is set to 3 for all 3 environments.

        This also adjusts the gunicorn async workers to 3 which is based
        on the fact, instances for all environments are set to 1vCpu.
        Where n = vCpus, we get 2n + 1 as a basis for setting the
        workers.  This can be adjust in the future if we ever change the
        number of vCpus per instance.

        Other things:
        * Remove some unused ENVs
        * Remove max-requests and max-requests-jitter
@dividehex dividehex requested a review from a team August 21, 2024 19:15
Copy link
Contributor

@gcoxmoz gcoxmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses the startup concerns from #501, tuning makes sense across the envs, looks right.

@dividehex dividehex merged commit 9a48f8b into master Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants