Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging with Google Cloud Logs #521

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Improve logging with Google Cloud Logs #521

merged 1 commit into from
Aug 23, 2024

Conversation

dividehex
Copy link
Contributor

    The primary purpose here is to improve logging to GCP by
    changing the logging formatter from plaintext to json.  The
    python logging config is now unified under logging.ini for both
    the flask application and gunicorn.

    Other changes are listed here:
    * Limits everret config sources to ENV only to avoid confusion
    * Removes sso-dashboard logger in favor of the root logger
    * Log Levels set to INFO unless SSO-DASHBOARD_DEBUG is set True
    * Adds a flask handler for uncaught Exceptions

        The primary purpose here is to improve logging to GCP by
        changing the logging formatter from plaintext to json.  The
        python logging config is now unified under logging.ini for both
        the flask application and gunicorn.

        Other changes are listed here:
        * Limits everret config sources to ENV only to avoid confusion
        * Removes sso-dashboard logger in favor of the root logger
        * Log Levels set to INFO unless SSO-DASHBOARD_DEBUG is set True
        * Adds a flask handler for uncaught Exceptions
@dividehex dividehex requested a review from a team August 23, 2024 13:52
@dividehex dividehex merged commit 5d7555c into master Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants