Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-10855 #23671 Change rating prompt request threshold (backport #24523) #24541

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 4, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Adjusting the rating prompt thresholds before we release it next week

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #24523 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner February 4, 2025 15:45
@mergify mergify bot added the conflicts label Feb 4, 2025
@mergify mergify bot requested review from OrlaM and removed request for a team February 4, 2025 15:45
Copy link
Contributor Author

mergify bot commented Feb 4, 2025

Cherry-pick of b7217ee has failed:

On branch mergify/bp/release/v135/pr-24523
Your branch is up to date with 'origin/release/v135'.

You are currently cherry-picking commit b7217ee09.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   firefox-ios/Client/CrashTracker.swift
	modified:   firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift
	modified:   firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift
	new file:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Helpers/CrashTrackerTests.swift
	new file:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Mocks/MockCrashTracker.swift
	new file:   firefox-ios/nimbus-features/ratingPromptFeature.yaml
	modified:   firefox-ios/nimbus.fml.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   firefox-ios/Client.xcodeproj/project.pbxproj
	both modified:   firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
	both modified:   firefox-ios/Client/RatingPromptManager.swift
	both modified:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Helpers/RatingPromptManagerTests.swift

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@lmarceau lmarceau added the weekly-release Tagging backports for rapid release label Feb 4, 2025
@lmarceau
Copy link
Contributor

lmarceau commented Feb 4, 2025

@rvandermeulen we need #24272 merged before we can merge this PR (hence the conflicts). Those two PRs needs to ship at the same time since the current PR adds the possibility to control the change with an experiment.

…adding experiment (backport #24523)

* Change rating prompt request threshold

* Add feature flag for rating prompt

* Oups

* Create crash tracker and related tests
@rvandermeulen rvandermeulen force-pushed the mergify/bp/release/v135/pr-24523 branch from cdc4fa4 to 13ea82f Compare February 7, 2025 15:11
Copy link
Contributor

@lmarceau lmarceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 135.1

@rvandermeulen rvandermeulen merged commit 6956b0c into release/v135 Feb 7, 2025
12 checks passed
@rvandermeulen rvandermeulen deleted the mergify/bp/release/v135/pr-24523 branch February 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts weekly-release Tagging backports for rapid release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants