-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FXIOS-10855 #23671 Change rating prompt request threshold (backport #24523) #24541
Conversation
Cherry-pick of b7217ee has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@rvandermeulen we need #24272 merged before we can merge this PR (hence the conflicts). Those two PRs needs to ship at the same time since the current PR adds the possibility to control the change with an experiment. |
…adding experiment (backport #24523) * Change rating prompt request threshold * Add feature flag for rating prompt * Oups * Create crash tracker and related tests
cdc4fa4
to
13ea82f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for 135.1
📜 Tickets
Jira ticket
Github issue
💡 Description
Adjusting the rating prompt thresholds before we release it next week
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)This is an automatic backport of pull request #24523 done by [Mergify](https://mergify.com).