wayland errata #139

aerickson · 2024-04-16T18:56:02Z

Aims to fix #138.

lissyx · 2024-04-16T19:08:18Z

scripts/ubuntu-jammy-from-community-gui/06-wayland_errrata.sh

+# ExecStartPre to `/bin/sleep 30`
+
+cp /lib/systemd/system/gdm3.service /etc/systemd/system/gdm3.service
+crudini --set /etc/systemd/system/gdm3.service Service ExecStartPre '/bin/sleep 30'


Make it 15 it looks like I used that value:

alissy@gecko-t-t-linux-2204-wayland-exp-aliss-dbc1lhxwqq66ty08ew5a-q:~$ grep sleep /etc/systemd/system/gdm3.service ExecStartPre=/bin/sleep 15 alissy@gecko-t-t-linux-2204-wayland-exp-aliss-dbc1lhxwqq66ty08ew5a-q:~$

lissyx · 2024-04-16T19:09:24Z

scripts/ubuntu-jammy-from-community-gui/06-wayland_errrata.sh

+# ExecStartPre to `/bin/sleep 30`
+
+cp /lib/systemd/system/gdm3.service /etc/systemd/system/gdm3.service
+crudini --set /etc/systemd/system/gdm3.service Service ExecStartPre '/bin/sleep 30'


also the existing gdm3.service already has a value set so I dont know how crudini will deal with that:

alissy@gecko-t-t-linux-2204-wayland-exp-aliss-dbc1lhxwqq66ty08ew5a-q:~$ grep ExecStartPre /lib/systemd/system/gdm3.service ExecStartPre=/usr/share/gdm/generate-config alissy@gecko-t-t-linux-2204-wayland-exp-aliss-dbc1lhxwqq66ty08ew5a-q:~$

I just checked the output and it appears to be able to redefine it.

lissyx · 2024-04-16T19:10:00Z

scripts/ubuntu-jammy-from-community-gui/06-wayland_errrata.sh

+# ExecStartPre to `/bin/sleep 30`
+
+cp /lib/systemd/system/gdm3.service /etc/systemd/system/gdm3.service
+crudini --set /etc/systemd/system/gdm3.service Service ExecStartPre '/bin/sleep 30'


(also we should make it clear this is a hack, there are better ways to do that but I need to verify it actually works)

comment added.

lissyx · 2024-04-16T19:12:04Z

scripts/ubuntu-jammy-from-community-gui/06-wayland_errrata.sh

+
+
+#
+# TODO: generate mutter's monitors.xml (only if needed)


it's needed, I just dont know exactly what we need to set for some values (connector, vendor, product, serial), e.g., mine on my laptop:

alex@portable-alex:~$ cat ~/.config/monitors.xml <monitors version="2"> <configuration> <logicalmonitor> <x>0</x> <y>0</y> <scale>1</scale> <primary>yes</primary> <monitor> <monitorspec> <connector>eDP-1</connector> <vendor>CSO</vendor> <product>0x1407</product> <serial>0x00000000</serial> </monitorspec> <mode> <width>3840</width> <height>2160</height> <rate>60.000</rate> </mode> </monitor> </logicalmonitor> </configuration> </monitors>

Should we just create one by hand and hope that the connector doesn't matter? How should we proceed?

see below: #139 (comment)

aerickson · 2024-04-16T20:50:00Z

Building the following at 4dd8748.

monopacker build gw_fxci_gcp_l1_gui --secrets_file real_secrets_l1.yaml --packer-args '-on-error=ask' produced gw-fxci-gcp-l1-gui-googlecompute-2024-04-16t19-58-50z.

aerickson · 2024-04-16T22:01:33Z

Building the following at 6ceed81.

monopacker build gw_fxci_gcp_l1_gui --secrets_file real_secrets_l1.yaml --packer-args '-on-error=ask' produced gw-fxci-gcp-l1-gui-googlecompute-2024-04-16t21-08-44z.

lissyx · 2024-04-17T07:48:11Z

scripts/ubuntu-jammy-from-community-gui/50-wayland_errrata.sh

@@ -105,5 +105,7 @@ apt install -y ubuntu-restricted-extras wl-clipboard


 #
-# TODO: generate mutter's monitors.xml (only if needed)
+# TODO: generate mutter's monitors.xml


So from https://firefox-ci-tc.services.mozilla.com/tasks/P-s9ONuKSSWIGcgPge-lJQ/runs/0/logs/public/logs/live_backing.log#L44 we can rely on that it seems:

$ cat /etc/xdg/monitors.xml <monitors version="2"> <configuration> <logicalmonitor> <x>0</x> <y>0</y> <scale>1</scale> <primary>yes</primary> <monitor> <monitorspec> <connector>Virtual-1</connector> <vendor>unknown</vendor> <product>unknown</product> <serial>unknown</serial> </monitorspec> <mode> <width>1920</width> <height>1080</height> <rate>60.000</rate> </mode> </monitor> </logicalmonitor> </configuration> </monitors>

lissyx · 2024-04-17T09:10:25Z

scripts/ubuntu-jammy-from-community-gui/50-wayland_errrata.sh

+
+# NOTES: this is a hack. alissy is working on a better solution.
+
+cp /lib/systemd/system/gdm3.service /etc/systemd/system/gdm3.service


delay gdm-service:

$ cat /etc/systemd/system/gdm.service.d/gdm-wait.conf [Unit] Description=Extra 30s wait [Service] ExecStartPre=/bin/sleep 30

lissyx · 2024-04-17T11:19:17Z

scripts/ubuntu-jammy-from-community-gui/50-wayland_errrata.sh

+
+# NOTES: this is a hack. alissy is working on a better solution.
+
+cp /lib/systemd/system/gdm3.service /etc/systemd/system/gdm3.service


So since I went to the new solution https://github.com/mozilla-platform-ops/monopacker/pull/139/files#r1568497122, I have not been able to reproduce any new failure ? https://firefox-ci-tc.services.mozilla.com/tasks/groups/aKRzjXn2R5GNNrpt_8ZAIA

Old hack removed and new gdm wait service added.

aerickson · 2024-04-17T22:38:17Z

Building the following at 2357dbc.

monopacker build gw_fxci_gcp_l1_gui --secrets_file real_secrets_l1.yaml --packer-args '-on-error=ask' produced gw-fxci-gcp-l1-gui-googlecompute-2024-04-17t21-57-05z.

lissyx · 2024-04-18T06:39:50Z

scripts/ubuntu-jammy-from-community-gui/50-wayland_errrata.sh

+
+
+#
+# gdm wait service file


We might want to explain that this is a hack required because without, on those workers, we end up in a situation where the wayland seat is in a weird state and consequences are:

either x11 session

either xwayland fallback

either wayland but with missing keyboard capability that breaks things including copy/paste

Thanks. I was unclear about why it was needed. Comment added.

aerickson · 2024-04-25T18:52:57Z

Alissy, are we happy with the current state of this PR/the image? Thanks!

lissyx · 2024-04-26T05:56:19Z

Alissy, are we happy with the current state of this PR/the image? Thanks!

I would need to run a few more tries to have a look, but it seems to be working good enough in my case. Whether it is OK for the whole m-c I can't tell, and assuming we dont have other changes (XDG_RUNTIME_DIR for example), I'd say I am happy.

lissyx · 2024-04-30T11:20:52Z

I am not sure what is the state of the current workers, but this is not complete (missing XDG_RUNTIME_DIR fixes?): https://treeherder.mozilla.org/jobs?repo=try&revision=3edc07891c47225f1b0af712c901c9604d717528

pull in https://github.com/taskcluster/taskcluster/releases/tag/v64.3.0

aerickson · 2024-05-16T16:58:46Z

Building the following at ca43828.

monopacker build gw_fxci_gcp_l1_gui --secrets_file real_secrets_l1.yaml --packer-args '-on-error=ask' produced gw-fxci-gcp-l1-gui-googlecompute-2024-05-15t21-40-31z.

lissyx · 2024-05-17T08:23:26Z

Building the following at ca43828.

monopacker build gw_fxci_gcp_l1_gui --secrets_file real_secrets_l1.yaml --packer-args '-on-error=ask' produced gw-fxci-gcp-l1-gui-googlecompute-2024-05-15t21-40-31z.

latest batch of retries from this morning: https://treeherder.mozilla.org/jobs?repo=try&revision=139d8f8ed0b12bcff0460370916e1b11d0a77683

they all came green, the orange was when the push to try was done and it was still running generic-worker 64.2.0, as verifiable in the logs

lissyx

We probably want to have something that checks if generic-worker installed does properly sets XDG_RUNTIME_DIR to prevent regressions, but I dont know where/how. Otherwise, retries after the deployment are green so it looks good enough to me

lissyx · 2024-05-17T08:24:26Z

scripts/ubuntu-jammy-from-community-gui/50-wayland_errrata.sh

+echo ttf-mscorefonts-installer msttcorefonts/accepted-mscorefonts-eula select true | sudo debconf-set-selections
+
+# install stuff
+apt install -y ubuntu-restricted-extras wl-clipboard


Debugging is done we dont need wl-clipboard anymore. Of course you might want to keep it if useful but I dont think we should.

wl-clipboard removed. Check for XDG_RUNTIME_DIR added.

aerickson · 2024-05-31T15:38:23Z

Building the following at 14a0da9.

monopacker build gw_fxci_gcp_l1_gui --secrets_file real_secrets_l1.yaml --packer-args '-on-error=ask' produced gw-fxci-gcp-l1-gui-googlecompute-2024-05-31t15-18-14z.

aerickson · 2024-06-04T19:18:42Z

Alissy is happy with the state of this I believe. We've shipped the latest revision to the main wayland image alias.

I think we're ready for a review and to merge this.

… r=relsre-reviewers,jmoss In support of https://mozilla-hub.atlassian.net/browse/RELOPS-928. See mozilla-platform-ops/monopacker#139. Differential Revision: https://phabricator.services.mozilla.com/D207815

…ard-majax Delivers an updated image built from mozilla-platform-ops/monopacker#139. Differential Revision: https://phabricator.services.mozilla.com/D210706

…-testing r=relsre-reviewers,rcurran Incorporates the latest changes from mozilla-platform-ops/monopacker#139. See https://mozilla-hub.atlassian.net/browse/RELOPS-928 for more information. Differential Revision: https://phabricator.services.mozilla.com/D212294

…glecompute-2024-05-31t15-18-14z r=relsre-reviewers,rcurran Promote the `monopacker-ubuntu-2204-wayland-aerickson-testing` image to `monopacker-ubuntu-2204-wayland`. Specifically set the `monopacker-ubuntu-2204-wayland` image alias to use `gw-fxci-gcp-l1-gui-googlecompute-2024-05-31t15-18-14z`. Alissy is happy with the tweaks PR (mozilla-platform-ops/monopacker#139) so let's release this to general availability. Differential Revision: https://phabricator.services.mozilla.com/D212585

lissyx reviewed Apr 16, 2024

View reviewed changes

lissyx reviewed Apr 17, 2024

View reviewed changes

lissyx reviewed Apr 18, 2024

View reviewed changes

aerickson added 15 commits May 15, 2024 14:35

work on wayland errata

6198317

last bits

3549ee4

add test

f3c0f2c

fix

70c160b

another bug fix

439c8e9

msoft font license workaround

3361391

sleep 15 vs 30

dbc78b3

add hack note

4745876

move crudini installation

0d2800a

comments, work on debug output

ec04f1e

rename files (spread out)

69f7190

add todo regarding mutter monitors.xml

ce57cba

comment cleanup, alissy's recommended changes

b945d10

create dir

d17ef9e

add note on hack

f40cc57

aerickson force-pushed the wayland_errata branch from 6e071e6 to f40cc57 Compare May 15, 2024 21:35

update TC components (has XDG env var fix)

ca43828

pull in https://github.com/taskcluster/taskcluster/releases/tag/v64.3.0

lissyx approved these changes May 17, 2024

View reviewed changes

aerickson added 3 commits May 28, 2024 18:22

wl-clipboard isn't needed any longer

c10b8e8

rename due to typo

4d20d8c

add check for the XDG_RUNTIME_DIR fix in g-w

14a0da9

aerickson requested a review from rcurranmoz June 4, 2024 19:18

rcurranmoz approved these changes Jun 4, 2024

View reviewed changes

aerickson merged commit 8af8f82 into mozilla-platform-ops:main Jun 4, 2024
2 checks passed

aerickson deleted the wayland_errata branch June 4, 2024 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wayland errata #139

wayland errata #139

aerickson commented Apr 16, 2024 •

edited

Loading

lissyx Apr 16, 2024

aerickson Apr 16, 2024

lissyx Apr 16, 2024

aerickson Apr 16, 2024 •

edited

Loading

lissyx Apr 16, 2024

aerickson Apr 16, 2024

lissyx Apr 16, 2024 •

edited

Loading

aerickson Apr 16, 2024

lissyx Apr 17, 2024 •

edited

Loading

aerickson commented Apr 16, 2024 •

edited

Loading

aerickson commented Apr 16, 2024

lissyx Apr 17, 2024

lissyx Apr 17, 2024

aerickson Apr 17, 2024

lissyx Apr 17, 2024 •

edited

Loading

lissyx Apr 17, 2024

aerickson Apr 17, 2024

aerickson commented Apr 17, 2024

lissyx Apr 18, 2024

aerickson Apr 18, 2024

aerickson commented Apr 25, 2024

lissyx commented Apr 26, 2024

lissyx commented Apr 30, 2024

aerickson commented May 16, 2024

lissyx commented May 17, 2024

lissyx left a comment

lissyx May 17, 2024

aerickson May 28, 2024

aerickson commented May 31, 2024

aerickson commented Jun 4, 2024


		# NOTES: this is a hack. alissy is working on a better solution.

		cp /lib/systemd/system/gdm3.service /etc/systemd/system/gdm3.service

wayland errata #139

wayland errata #139

Conversation

aerickson commented Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerickson Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lissyx Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lissyx Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

aerickson commented Apr 16, 2024 • edited Loading

aerickson commented Apr 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lissyx Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerickson commented Apr 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerickson commented Apr 25, 2024

lissyx commented Apr 26, 2024

lissyx commented Apr 30, 2024

aerickson commented May 16, 2024

lissyx commented May 17, 2024

lissyx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerickson commented May 31, 2024

aerickson commented Jun 4, 2024

aerickson commented Apr 16, 2024 •

edited

Loading

aerickson Apr 16, 2024 •

edited

Loading

lissyx Apr 16, 2024 •

edited

Loading

lissyx Apr 17, 2024 •

edited

Loading

aerickson commented Apr 16, 2024 •

edited

Loading

lissyx Apr 17, 2024 •

edited

Loading