Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to go.uber.org/gomock #1093

Merged
merged 1 commit into from
Jan 15, 2025
Merged

migrate to go.uber.org/gomock #1093

merged 1 commit into from
Jan 15, 2025

Conversation

jmhodges
Copy link
Contributor

@jmhodges jmhodges commented Jan 13, 2025

The github.com/golang/mock project is no longer maintained and has been archived.

The go.uber.org/mock project is a fork of golang/mock that is actively
maintained.

So, we do the work to recreate the mocks with the new library. The
internal/mockstatsd one was already using the go.uber.org/mock library
and so doesn't need to change.

@jmhodges jmhodges force-pushed the migrate-to-uber-mockgen branch from 4b63ec6 to e206395 Compare January 13, 2025 21:29
@jmhodges jmhodges changed the title migrate to uber mockgen migrate to go.uber.org/gomock Jan 13, 2025
@jmhodges jmhodges force-pushed the migrate-to-uber-mockgen branch from e206395 to 78eac60 Compare January 13, 2025 21:31
The github.com/golang/mock project is no longer maintained and has been archived.

The go.uber.org/mock project is a fork of golang/mock that is actively
maintained.

So, we do the work to recreate the mocks with the new library. The
internal/mockstatsd one was already using the go.uber.org/mock library
and so doesn't need to change.
@jmhodges jmhodges force-pushed the migrate-to-uber-mockgen branch from 78eac60 to 8e82718 Compare January 13, 2025 21:32
@jmhodges jmhodges marked this pull request as ready for review January 13, 2025 21:49
@jmhodges jmhodges requested review from a team as code owners January 13, 2025 21:49
@jmhodges jmhodges requested review from alexcottner and removed request for a team January 13, 2025 21:49
@jmhodges jmhodges merged commit c5274b6 into main Jan 15, 2025
14 checks passed
@jmhodges jmhodges deleted the migrate-to-uber-mockgen branch January 15, 2025 17:10
@say-yawn
Copy link
Contributor

Related to: AUT-238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants