remove unneeded grep of staticcheck output #914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges
force-pushed
the
remove-staticcheck-grep
branch
from
a36207f
to
106e823
Compare
|
(Found will digging around in why an earlier draft of #911 didn't include everything it needed) |
This grep was a hack to avoid fixing a deprecated API for DSA. The grep command fails on macOS because `-P` doesn't exist on the default macOS grep. Fortunately, the use of the deprecated API was corrected in #770 (original ticket: #667), so we can just drop it whole cloth. In the future, I believe we'll want to use staticcheck's built-in ways of ignoring certain lints, anyway: https://staticcheck.io/docs/configuration/#ignoring-problems
jmhodges
force-pushed
the
remove-staticcheck-grep
branch
from
106e823
to
804fd54
Compare
|
Mooted by #951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This grep was a hack to avoid fixing a deprecated API for DSA. The grep
command fails on macOS because
-Pdoesn't exist on the default macOSgrep.
Fortunately, the use of the deprecated API was corrected in
#770 (original ticket:
#667), so we can
just drop it whole cloth.
In the future, I believe we'll want to use staticcheck's built-in ways
of ignoring certain lints, anyway:
https://staticcheck.io/docs/configuration/#ignoring-problems