Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ./... alias instead of PACKAGE_NAMES #949

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

jmhodges
Copy link
Contributor

@jmhodges jmhodges commented Aug 15, 2024

Now that we've stopped our tools from conflicting over func main, we
can use the Go tooling's ./... alias to make them operate over all of
our packages. See go help packages for more on .... (Those conflicts
were solved in #947).

This means we no longer have to remember to update this variable every
time we want to test or lint a new package in CI and locally.

@jmhodges jmhodges force-pushed the remove-package-names branch 2 times, most recently from 217a5b1 to 0046a61 Compare August 15, 2024 14:47
@jmhodges jmhodges force-pushed the remove-package-names branch 2 times, most recently from 95928a5 to 8907752 Compare August 26, 2024 18:16
@jmhodges jmhodges marked this pull request as ready for review August 26, 2024 18:49
@jmhodges jmhodges requested review from a team as code owners August 26, 2024 18:49
@jmhodges jmhodges requested review from oskirby and removed request for a team August 26, 2024 18:49
.circleci/config.yml Outdated Show resolved Hide resolved
@jmhodges jmhodges changed the base branch from move-main to main August 26, 2024 18:54
Copy link
Contributor

@hneiva hneiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Now that we've stopped our tools from conflicting over `func main`, we
can use the Go tooling's `./...` alias to make them operate over all of
our packages. See `go help packages` for more on `...`. (Those conflicts
were solved in #947).

This means we no longer have to remember to update this variable every
time we want to test or lint a new package in CI and locally.

Updates AUT-192
@jmhodges jmhodges merged commit 4b4c830 into main Aug 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants