feat: Add metrics for ACK codes. #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
reviewed
Oct 30, 2024
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/unidentified.rs
Outdated
Show resolved
Hide resolved
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/identified/mod.rs
Outdated
Show resolved
Hide resolved
jrconlin
commented
Oct 30, 2024
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/identified/on_server_notif.rs
Outdated
Show resolved
Hide resolved
This adds metrics for
* `ua.command.ack.unknown_version` indicating ACK responses from the
desktop UA that do not match known, send notifications.
* `ua.command.ack {code: ###}` recording ACK'd messages broken out by
returned `code`
Closes: SYNC-4456
jrconlin
force-pushed
the
feat/SYNC-4456_track_code
branch
from
4b9e6b5
to
50a7536
Compare
The notification version is the message_id. The message_id is an encrypted string containing the uaid, chid, topic or timestamp, etc. No need to check the channelId, since the version/message_id should already have it.
… feat/SYNC-4456_track_code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metrics for
ua.command.ack.unknown_versionindicating ACK responses from thedesktop UA that do not match known, send notifications.
ua.command.ack {code: ###}recording ACK'd messages broken out byreturned
codeCloses: SYNC-4456