Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse PRs from Release notes 🚀 #15

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Parse PRs from Release notes 🚀 #15

merged 6 commits into from
Jan 2, 2024

Conversation

hackebrot
Copy link
Member

Resolve #13

@hackebrot hackebrot added the feature New feature or request label Dec 18, 2023
@hackebrot hackebrot requested a review from a team December 18, 2023 16:25
mtbottle
mtbottle approved these changes Dec 19, 2023
View reviewed changes
Copy link

@mtbottle mtbottle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM! I noticed that only a few of our services actually follow the auto-generated release notes format, so we might not get a huge coverage with this. I think Monitor at least is using this format, so that's good enough to get started with!

@hackebrot
Copy link
Member Author

Hi @mtbottle! 👋🏻

Thanks for the review. Yes, that's correct!

This is not a universal solution and we'll need more to cover all scenarios.

@hackebrot hackebrot added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 56ff822 Jan 2, 2024
2 checks passed
@hackebrot hackebrot deleted the parse-prs-from-release-notes branch January 2, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtbottle mtbottle mtbottle approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse GitHub Pull Requests from Release description 📋
2 participants
@hackebrot @mtbottle