Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CODEOWNERS file pointing to invalid team. #613

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix CODEOWNERS file pointing to invalid team. #613

merged 1 commit into from
May 17, 2024

Conversation

Trikolon
Copy link
Contributor

No description provided.

@Trikolon Trikolon requested a review from artines1 May 14, 2024 16:43
@Trikolon
Copy link
Contributor Author

We could also add separate code owners for the list files and for the rest of the repo (including the script) since we have two teams

shavar_people and shavar_reviewers. But maybe that's overly complicated.

artines1
artines1 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@artines1 artines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I didn't catch this before.

@Trikolon Trikolon mentioned this pull request May 17, 2024
Merged
@Trikolon Trikolon merged commit 499ce1e into master May 17, 2024
2 checks passed
@Trikolon Trikolon deleted the fix-codeowners branch June 20, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artines1 artines1 artines1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trikolon @artines1